We are searching for new editors to keep track of Girls' Frontline 2 content, as well as veteran players to complete the data of Girls' Frontline and Project Neural Cloud characters.
You can contribute without an account. Learn how to contribute and join our Discord server.
MediaWiki:Gadget-SkillForm.js: Difference between revisions
No edit summary |
BryghtShadow (talk | contribs) normalize filenames; resolve some JSHint annotations. |
||
| Line 138: | Line 138: | ||
} | } | ||
var i; // For i not being global :) | var i, var_name; // For i and var_name not being global :) | ||
if($('.maxanalysis input').is(':checked')) { | if($('.maxanalysis input').is(':checked')) { | ||
for (i = 0; i < vars.length; i++) { | for (i = 0; i < vars.length; i++) { | ||
var_name = vars[i].substring(2, vars[i].length - 1);// Trim beginning $( and trailing ) | var_name = vars[i].substring(2, vars[i].length - 1);// Trim beginning $( and trailing ) | ||
var_name_max = var_name + '_4'; | var var_name_max = var_name + '_4'; | ||
if (typeof data[var_name_max] !== 'undefined'){// If defined, use max analysis data instead of base data | if (typeof data[var_name_max] !== 'undefined'){// If defined, use max analysis data instead of base data | ||
resultText = resultText.replace(vars[i], "<span class='skill-value'>" + data[var_name_max][chosenLevelIdx] + "</span>"); | resultText = resultText.replace(vars[i], "<span class='skill-value'>" + data[var_name_max][chosenLevelIdx] + "</span>"); | ||
| Line 248: | Line 248: | ||
var iconImg = skillDataContainer.find('.skillicon img'); | var iconImg = skillDataContainer.find('.skillicon img'); | ||
var iconId = data.icon || ""; | var iconId = data.icon || ""; | ||
// Normalize filenames | |||
iconId = iconId.replace(/ /g, '_'); | |||
var iconFilename = "Icon_Skill_" + iconId + ".png"; | var iconFilename = "Icon_Skill_" + iconId + ".png"; | ||
if (iconImg.attr('alt') != iconFilename) { | if (iconImg.attr('alt') != iconFilename) { | ||
iconImg.attr('alt', iconFilename); | iconImg.attr('alt', iconFilename); | ||
var wikiPath = "/images/" + gfUtils.createWikiPathPart(iconFilename) + iconFilename; | var wikiPath = "/images/" + gfUtils.createWikiPathPart(iconFilename) + iconFilename; | ||
var fallbackPath = "/images/thumb/5/5b/skill_backup.png/75px-skill_backup.png 1.5x, /images/5/5b/skill_backup.png 2x" | var fallbackPath = "/images/thumb/5/5b/skill_backup.png/75px-skill_backup.png 1.5x, /images/5/5b/skill_backup.png 2x"; | ||
iconImg.attr('src', wikiPath); | iconImg.attr('src', wikiPath); | ||
if (iconId == '' || iconId == null) { | if (iconId == '' || iconId == null) { | ||
| Line 260: | Line 262: | ||
var img = new Image(); | var img = new Image(); | ||
img.src = wikiPath; | img.src = wikiPath; | ||
img.onload = function(){ iconImg.attr('srcset', wikiPath + " 1.5x"); } | img.onload = function(){ iconImg.attr('srcset', wikiPath + " 1.5x"); }; | ||
img.onerror = function(){ iconImg.attr('srcset', fallbackPath); } | img.onerror = function(){ iconImg.attr('srcset', fallbackPath); }; | ||
} | } | ||
} | } | ||